RFR: 8257967: JFR: Events for loaded agents [v15]

[Markus Grönlund]

On Sat, 1 Apr 2023 03:31:48 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixes
>
> src/hotspot/share/prims/agent.hpp line 1:
> 
>> 1: /*
> 
> The name for class and file is too general.
> I'm thinking if renaming the files to jvmtiAgent and the class to JvmtiAgent would work.
> In general, there exists a convention to name JVMTI file with the "jvmti" prefix.
> It is a gray zone between Runtime and JVMTI but seems to belong more to JVMTI.
> The same about the AgentList class and file.
> Also, these new files are good candidates to add here:
> 
> make/hotspot/lib/JvmFeatures.gmk:
> ifneq ($(call check-jvm-feature, jvmti), true)
>   JVM_CFLAGS_FEATURES += -DINCLUDE_JVMTI=0
>   JVM_EXCLUDE_FILES += jvmtiGetLoadedClasses.cpp jvmtiThreadState.cpp jvmtiExtensions.cpp \
>       jvmtiImpl.cpp jvmtiManageCapabilities.cpp jvmtiRawMonitor.cpp jvmtiUtil.cpp jvmtiTrace.cpp \
>       jvmtiCodeBlobEvents.cpp jvmtiEnv.cpp jvmtiRedefineClasses.cpp jvmtiEnvBase.cpp jvmtiEnvThreadState.cpp \
>       jvmtiTagMap.cpp jvmtiEventController.cpp evmCompat.cpp jvmtiEnter.xsl jvmtiExport.cpp \
>       jvmtiClassFileReconstituter.cpp jvmtiTagMapTable.cpp
> endif

Hi Sergui, thanks for taking a look.

I have updated with the names you suggested. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12923#discussion_r1157362083