RFR: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors

Frederic Parain fparain at openjdk.org
Tue Apr 4 17:57:07 UTC 2023


On Tue, 4 Apr 2023 07:44:40 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> CommandProcessor command "dumpclass" produces classes with invalid field descriptors. 
> 
> Proposed patch fixes `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return correct `getSignatureIndex` instead of invalid `getGenericSignatureIndex`.
> 
> Added condition to  `ClhsdbDumpclass` test assures no errors are reported by `javap` in the dumped classes.
> 
> Please review.
> 
> Thank you,
> Adam

Looks good to me.
Thank you for fixing this.

Fred

-------------

Marked as reviewed by fparain (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13321#pullrequestreview-1371500110


More information about the serviceability-dev mailing list