RFR: 8305608: Change VMConnection to use "test.class.path"instead of "test.classes"
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Apr 4 23:11:06 UTC 2023
On Tue, 4 Apr 2023 20:42:34 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> Currently, VMConnection run debugee using "test.classes" as a classpath. It cause test failures when virtual thread factory (wrapper) is enabled and test is not located the same directory as TestScaffold.
test/jdk/com/sun/jdi/VMConnection.java line 54:
> 52: // When we run under jtreg, test.classes contains the pathname of
> 53: // the dir in which the .class files will be placed.
> 54: // When we run jtreg with plugin, the TestScaffold should be also in classpath
A stupid question about this part of comment: `the TestScaffold should be also in classpath`.
If it should be ALSO in classpath then why in the `Virtual` case we use "test.class.path" instead of "test.classes" but not both. It'd be good to clarify this in the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13339#discussion_r1157850857
More information about the serviceability-dev
mailing list