RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v4]
Roger Riggs
rriggs at openjdk.org
Wed Apr 5 20:52:15 UTC 2023
On Wed, 5 Apr 2023 20:31:43 GMT, Bernd <duke at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> test/jdk/jdk/internal/util/ArchTest.java line 58:
>
>> 56: @Test
>> 57: public void nameVsCurrent() {
>> 58: String osArch = System.getProperty("os.arch").toLowerCase(Locale.ROOT);
>
> Is it planned to determine os.arch with the same enum in the future (keeping the legacy names)?
That's a different set of twisty build and native source files, I'll create an issue to re-visit that.
It may not change too much, the native code needs to initialize `os.arch` very early.
[JDK-8305676](https://bugs.openjdk.org/browse/JDK-8305676)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159009755
More information about the serviceability-dev
mailing list