RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v4]

Jorn Vernee jvernee at openjdk.org
Wed Apr 5 23:42:13 UTC 2023


On Wed, 5 Apr 2023 19:20:08 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, PPC64LE`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The values of the system property `os.arch` is unchanged.
>> 
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct spelling of isAARCH64 in WIndows AttachProviderImpl

test/jdk/java/foreign/TestUnsupportedLinker.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @ignore architecture can not be overridden by setting os.arch - delete test

FWIW, we introduce a property in CABI to override it directly in the JEP patch: https://github.com/openjdk/jdk/pull/13079/files#diff-1e9526318ae485495af012cbf0450693d77fd8241be62afe422a75304de5aed1R28

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159130445


More information about the serviceability-dev mailing list