RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

[Phil Race]

On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, PPC64LE`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The values of the system property `os.arch` is unchanged.
>> 
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unneeded qualified export from java.base to jdk.attach

src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java line 169:

> 167:         // Load the appropriate DLLs
> 168:         boolean is32on64 = false;
> 169:         if (Architecture.isX86()) {

This would be another coupling of java.desktop into java.base internals and I don't think it worth it.
Particularly because this check is obsolete !
It is a remnant of when accessbridge was an unbundled download so provided both 32 and 64 bit.
We don't even have  the file it is looking for in the build - even if someone did a 32 bit build.
Instead of making this change a bug should be filed to remove this code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160314934