RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v4]

Alex Menkov amenkov at openjdk.org
Fri Apr 7 04:51:39 UTC 2023


On Fri, 7 Apr 2023 02:27:59 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   trailing spaces
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/libVThreadStackRefTest.cpp line 179:
> 
>> 177: }
>> 178: 
>> 179: static volatile bool timeToExit = false;
> 
> It is not enough to make variable volatile in c++. You need to make it atomic or use monitors to correctly synchronize.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1160432556


More information about the serviceability-dev mailing list