RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]
ExE Boss
duke at openjdk.org
Fri Apr 7 09:10:49 UTC 2023
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, PPC64LE`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The values of the system property `os.arch` is unchanged.
>>
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove unneeded qualified export from java.base to jdk.attach
src/jdk.attach/windows/classes/sun/tools/attach/AttachProviderImpl.java line 38:
> 36:
> 37: import jdk.internal.util.Architecture;
> 38:
Not removed in [commit `ab084c2` or `52ca4a7`](https://github.com/openjdk/jdk/pull/13357/files/105ce60528f7ef84e31ac3db64e6eb63860b4a70..52ca4a70fc3de9e285964f9545ea8cd54e2d9924):
Suggestion:
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1160563815
More information about the serviceability-dev
mailing list