RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

Serguei Spitsyn sspitsyn at openjdk.org
Mon Apr 10 18:53:04 UTC 2023


On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Updated VM internal object allocation C2 intrinsic to post jvmti events when needed.

It looks pretty good. But I'd like to request a couple of changes.
The `notify_allocation` sounds to generic.
What about to replace it with `notify_jvmti_vm_object_alloc`?
I'll post another request separately.

src/hotspot/share/opto/library_call.cpp line 2856:

> 2854:   set_result(ideal.value(result));
> 2855:   return true;
> 2856: #else

Nit: It is better to replace #else at 2856 with #endif. Then #endif at 2859 is not needed.

-------------

Changes requested by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13312#pullrequestreview-1377960281
PR Review Comment: https://git.openjdk.org/jdk/pull/13312#discussion_r1161981967


More information about the serviceability-dev mailing list