RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

Serguei Spitsyn sspitsyn at openjdk.org
Mon Apr 10 19:00:58 UTC 2023


On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Updated VM internal object allocation C2 intrinsic to post jvmti events when needed.

src/hotspot/share/prims/jvmtiEventController.cpp line 727:

> 725:     JvmtiExport::set_should_post_on_exceptions((any_env_thread_enabled & SHOULD_POST_ON_EXCEPTIONS_BITS) != 0);
> 726: 
> 727:     JvmtiExport::_should_post_allocation_notifications = JvmtiExport::should_post_vm_object_alloc();

I'm not sure why this flag is needed. It looks like a dup of `JvmtiExport::should_post_vm_object_alloc()`.
Can we just replace it with `JvmtiExport::should_post_vm_object_alloc()`?

test/hotspot/jtreg/ProblemList-Xcomp.txt line 41:

> 39: serviceability/sa/TestJhsdbJstackMixed.java 8248675 linux-aarch64
> 40: 
> 41: serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java 8288430 generic-all

If the 8288430 is a dup of 8277573 then should we close it as such?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13312#discussion_r1161989234
PR Review Comment: https://git.openjdk.org/jdk/pull/13312#discussion_r1161990486


More information about the serviceability-dev mailing list