RFR: 8305084: Remove finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/ that are used in serviceability/dcmd/gc/

David Holmes dholmes at openjdk.org
Tue Apr 11 11:00:34 UTC 2023


On Tue, 11 Apr 2023 10:20:25 GMT, Afshin Zafari <duke at openjdk.org> wrote:

> The `removal` warnings are suppressed out.
> Test:
> `FinalizerInfoTest` and `RunFinalizationTest` are executed locally.

Suppression of warning is fine but the bug synopsis (and so PR title) needs to be updated to reflect what is actually happening here. And the bug title doesn't really make sense anyway - why is the test location given twice ??

Thanks

test/hotspot/jtreg/serviceability/dcmd/gc/FinalizationRunner.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

Copyright change is wrong - should be "2015, 2023,"

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13423#pullrequestreview-1378979810
PR Review Comment: https://git.openjdk.org/jdk/pull/13423#discussion_r1162643632


More information about the serviceability-dev mailing list