RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v9]
Roger Riggs
rriggs at openjdk.org
Tue Apr 11 17:00:51 UTC 2023
On Tue, 11 Apr 2023 11:41:24 GMT, Glavo <duke at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unused static and import of Stabile
>
> src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template line 68:
>
>> 66: // The variables are named to match the Architecture value names, and
>> 67: // the values are named to match the build variables.
>> 68: static final boolean TARGET_ARCH_IS_X64 = "@@OPENJDK_TARGET_CPU@@" == "x86_64";
>
> Would it be better to rename the enum entry to `X86_64`? I personally prefer the name x86-64 because I feel it is more regular than x64..
> Would be great if you could support "os.arch = ppc64" for AIX and legacy linux, too.
Changing os.arch is out of scope for this PR.
The best way for that would someone supporting ppc to develop and propose a PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1163098619
More information about the serviceability-dev
mailing list