RFR: 8257967: JFR: Events for loaded agents [v16]

Markus Grönlund mgronlun at openjdk.org
Thu Apr 13 12:16:18 UTC 2023


On Thu, 13 Apr 2023 10:24:55 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renames
>
> src/hotspot/share/prims/jvmtiAgentList.cpp line 72:
> 
>> 70: // there exist an order requirement to iterate oldest -> newest. Our concurrent storage linked-list is newest -> oldest.
>> 71: // The correct order is preserved by the iterator, by storing a filtered set of entries in a stack.
>> 72: JvmtiAgentList::Iterator::Iterator(JvmtiAgent** list, Filter filter) : _stack(new GrowableArrayCHeap<JvmtiAgent*, mtServiceability>(16)), _filter(filter) {
> 
> Nit: It'd be nice to make the lines 69-72 shorter.

Ok. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12923#discussion_r1165429976


More information about the serviceability-dev mailing list