RFR: 8305937: com/sun/jdi/SetLocalWhileThreadInNative.java fails with -XX:+TieredCompilation

Daniel D. Daugherty dcubed at openjdk.org
Thu Apr 13 15:49:35 UTC 2023


On Thu, 13 Apr 2023 14:49:58 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Could you please review following trivial fix which correct jvm options order in TestScaffold.
> TestScaffold combines test optionos and jtreg vm options. Before [JDK-8304834](https://bugs.openjdk.org/browse/JDK-8304834) it passed test jvm args as part of targetAppCommandLine. So the test VM args are added to the jtreg vm options. But after JDK-8304834 it parse then into targetVMArgs. So test vm args should append to jtreg vm options to override them.
> 
> Testing: tier1-tier5 (including failing combination and testing with wrapper)
> I haven't added requires to filter out the test, because e filter only failing combination usually.

Thumbs up. This is a trivial fix.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13462#pullrequestreview-1383729766


More information about the serviceability-dev mailing list