RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v13]
Roger Riggs
rriggs at openjdk.org
Mon Apr 17 17:31:52 UTC 2023
On Sat, 15 Apr 2023 17:17:13 GMT, Glavo <duke at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the build
>> to avoid multiple mappings in more than one place.
>
> test/jdk/jdk/internal/util/ArchTest.java line 70:
>
>> 68: case "x86", "i386" -> X86;
>> 69: case "aarch64" -> AARCH64;
>> 70: case "riscv64" -> RISCV64; // unverified
>
> Suggestion:
>
> case "riscv64" -> RISCV64;
@Glavo Thanks for verifying.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1169059529
More information about the serviceability-dev
mailing list