RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v7]
Chen Liang
liach at openjdk.org
Wed Apr 19 01:11:00 UTC 2023
On Tue, 21 Mar 2023 21:39:48 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html and I may update this patch shall the API changes be integrated before
>> 2. One ASM library-specific test, `LambdaAsm` is removed. Others have their code generation infrastructure upgraded from ASM to Classfile API.
>> 3. Most tests are included in tier1, but some are not:
>> In `:jdk_io`: (tier2, part 2)
>>
>> test/jdk/java/io/Serializable/records/SerialPersistentFieldsTest.java
>> test/jdk/java/io/Serializable/records/ProhibitedMethods.java
>> test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java
>>
>> In `:jdk_instrument`: (tier 3)
>>
>> test/jdk/java/lang/instrument/RetransformAgent.java
>> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java
>> test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>>
>>
>> @asotona Would you mind reviewing?
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>
> - Switch to ConstantDescs for <init> <clinit> and void constants
> - Merge AnnotationsTest, remove ModuleTargetAttribute call
> - Merge branch 'invoke-test-classfile' of https://github.com/liachmodded/jdk into invoke-test-classfile
> - Update test/jdk/java/lang/invoke/8022701/MHIllegalAccess.java
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
> - Merge branch 'master' into invoke-test-classfile
> - Fix LambdaStackTrace after running
> - formatting
> - Fix failed LambdaStackTrace test, use more convenient APIs
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into invoke-test-classfile
> - Shorten lines, move from mask() to ACC_ constants, other misc improvements
> - ... and 1 more: https://git.openjdk.org/jdk/compare/0deb6489...7dc785b3
keep alive. this might not be integrated until classfile api has been previewed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13009#issuecomment-1513989606
More information about the serviceability-dev
mailing list