RFR: 8306282: Build failure linux-arm32-open-cmp-baseline after JDK-8257967 [v3]

[David Holmes]

On Tue, 18 Apr 2023 15:22:02 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> With [JDK-8257967](https://bugs.openjdk.org/browse/JDK-8257967), much refactoring was done to the JVMTI code concerning agents. However, some platforms do not have JVMTI support, and tier5 of testing builds an embedded build,  linux-arm32-open-cmp-baseline, which failed because the refactoring did not properly handle conditional compilations for JVMTI.
>> 
>> JDK-8257967 did run tier5, but it used an existing build, so it did not cause recompilations of the embedded target :-(
>> 
>> This changeset adds the conditional constructs to let linux-arm32-open-cmp-baseline build successfully.
>> 
>> It does not look good, but there you go...
>> 
>> Testing:
>> 
>> Building: linux-arm32-open-cmp-baseline
>> Building: regular platforms
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   SIZE_FORMAT

@mgronlun I agree this does not look good. I'm not sure this was the right way to conditionalize the new code, rather than ensuring the callsites were conditionalized on INCLUDE_JVMTI.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13512#issuecomment-1514041621