RFR: 8306006: strace001.java fails due to unknown methods on stack [v2]
David Holmes
dholmes at openjdk.org
Wed Apr 19 12:42:49 UTC 2023
On Wed, 19 Apr 2023 11:30:42 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:
>> Added the missing java.lang.Thread.beforeSleep and java.lang.afterSleep to expectedSystemTrace.
>> Tested on my local machine.
>
> Fredrik Bredberg has updated the pull request incrementally with two additional commits since the last revision:
>
> - Updated after review
> - Added java.util.concurrent.TimeUnit.toNanos to expectedSystemTrace
Final version looks good - thanks!
A follow up would be to check what each of these test variants are supposed to do, because AFAICS the `-testMode` argument is never used.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13476#pullrequestreview-1391970240
More information about the serviceability-dev
mailing list