RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

[David Holmes]

On Thu, 20 Apr 2023 16:40:48 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> This enhancement adds support of virtual threads to the JVMTI `StopThread` function.
>> In preview releases before this enhancement the StopThread returned the JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>> 
>> The `StopThread` supports sending an asynchronous exception to a virtual thread only if it is current or suspended at mounted state. For instance, a virtual thread can be suspended at a JVMTI event. If the virtual thread is not suspended and is not current then the `JVMTI_ERROR_THREAD_NOT_SUSPENDED` error code is returned. If the virtual thread was suspended at unmounted state then the `JVMTI_ERROR_OPAQUE_FRAME` error code is returned.
>> 
>> The `StopThread` has the following description for `JVMTI_ERROR_OPAQUE_FRAME` error code:
>>> The thread is a suspended virtual thread and the implementation 
>>> was unable to throw an asynchronous exception from this frame.
>> 
>> A couple of the `serviceability/jvmti/vthread` tests has been updated to adopt to new `StopThread` behavior.
>> 
>> The CSR is: https://bugs.openjdk.org/browse/JDK-8306434
>> 
>> Testing:
>> The mach5 tears 1-6 are in progress.
>> Preliminary test runs were good in general.
>> The JDB test `vmTestbase/nsk/jdb/kill/kill001/kill001.java` has been problem-listed and will be fixed by the corresponding debugger enhancement which is going to adopt JDWP/JDI specs to new behavior of the JVMTI `StopThread` related to virtual threads.
>> 
>> Also, two JCK JVMTI tests are failing in the tier-6 :
>>> vm/jvmti/StopThread/stop001/stop00103/stop00103.html
>>> vm/jvmti/StopThread/stop001/stop00103/stop00103a.html
>> 
>> These two tests will be excluded from the test runs by the JCK team and then adjusted to new `StopThread` behavior.
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressed review comments on new test

src/hotspot/share/prims/jvmtiEnv.cpp line 1200:

> 1198:     }
> 1199:     if (java_thread == nullptr) { // unmounted virtual thread
> 1200:       return JVMTI_ERROR_OPAQUE_FRAME;

Where is the check for "suspended at an event" that otherwise results in `JVMTI_ERROR_OPAQUE_FRAME`?

test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java line 33:

> 31:  *     Its method run() invokes the following methods:
> 32:  *      - method A() that is blocked on a monitor
> 33:  *      - method B() that is stopped at a brakepoint

s/brakepoint/breakpoint/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1173352162
PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1173356185