RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v16]

Feilong Jiang fjiang at openjdk.org
Fri Apr 21 06:43:06 UTC 2023


On Fri, 21 Apr 2023 02:33:37 GMT, SUN Guoyun <duke at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   s390x NULL to nullptr
>
> src/hotspot/cpu/riscv/templateTable_riscv.cpp line 2233:
> 
>> 2231: 
>> 2232:   __ load_resolved_indy_entry(cache, index);
>> 2233:   __ membar(MacroAssembler::AnyAny);
> 
> Why is the AnyAny barrier used here?

Hi @sunny868, I'm working on removing these unnecessary barriers. RISC-V port uses more conservative barriers like this for some reasons (e.g.: [1][2][3]),  we can just remove them. 

1. https://github.com/openjdk/jdk/blob/36ec05d52a79185d8c6669713fd17933128c032a/src/hotspot/cpu/riscv/templateTable_riscv.cpp#L3438-L3443
2. https://github.com/openjdk/jdk/blob/36ec05d52a79185d8c6669713fd17933128c032a/src/hotspot/cpu/riscv/templateTable_riscv.cpp#L3558-L3563
3. https://github.com/openjdk/jdk/blob/36ec05d52a79185d8c6669713fd17933128c032a/src/hotspot/cpu/riscv/templateTable_riscv.cpp#L3614-L3619

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12778#discussion_r1173362912


More information about the serviceability-dev mailing list