RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Apr 21 18:36:46 UTC 2023


On Fri, 21 Apr 2023 16:33:06 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   corrections for BoundVirtualThread and test typos
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java line 135:
> 
>> 133:             // StopThread is expected to succeed.
>> 134:             testTask.ensureFinished();
>> 135:         }
> 
> I don't see how this is doing any testing. Where is the stopThread(null) call?

The target virtual thread just continues and invokes method `C()` which sends asynchronous exception with JVMTI `StopThread` to current thread:

        // This method uses StopThread to send an AssertionError object to
        // its own thread. It is expected to succeed.
        static void C() {
            log("TestTask.C: started");
            StopThreadTest.stopThread(Thread.currentThread());
            log("TestTask.C: finished");
        }

I'll try to add a comment to make it clear.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1174062854


More information about the serviceability-dev mailing list