RFR: 8306836: Remove pinned tag for G1 heap regions

Thomas Schatzl tschatzl at openjdk.org
Tue Apr 25 13:57:20 UTC 2023


Hi all,

  please review this change that removes the pinned tag from `HeapRegion`.

So that "pinned" tag for G1 heap regions indicates that the region should not move during (young) gc. This applies to now removed archive regions and humongous objects/regions.

With "real" g1 region pinning to deal with gclocker in g1 once and for all upcoming we need a refcount, a single bit is not sufficient anymore. Further there will be a naming conflict as this kind of "pinning" is different to g1 region pinning "pinning". The former indicates "contents can not be moved, but can be reclaimed", while the latter means "contents can not be moved and not reclaimed".

The (current) pinned flag is surprisingly little used, only for policy decisions.

The suggestion this change implements is to remove the "pinned" tag as it is, and reserve it for future g1 region pinning (that needs to store the pinning attribute differently anyway).

Testing: tier1-3, gha

Thanks,
  Thomas

-------------

Commit messages:
 - Fix hsdb
 - compilation fixes
 - Initial implementation

Changes: https://git.openjdk.org/jdk/pull/13643/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13643&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8306836
  Stats: 66 lines in 20 files changed: 16 ins; 22 del; 28 mod
  Patch: https://git.openjdk.org/jdk/pull/13643.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13643/head:pull/13643

PR: https://git.openjdk.org/jdk/pull/13643


More information about the serviceability-dev mailing list