RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the same time

Serguei Spitsyn sspitsyn at openjdk.org
Wed Apr 26 09:50:54 UTC 2023


On Tue, 25 Apr 2023 15:50:24 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Agree, it is confusing, even in standard j.l.Process API . The `InputStream java.lang.Process.getInputStream()`" returns **output** stream of started process.  So for our implementation ProcessImpl the 'out' and 'err' mean output and error streams. However they are returned as InputStreams so users could read them.
>
> Right. From the API caller's POV, it is asking for InputStreams that it can use to read the process' stdout or stderr streams.

Okay, thanks.
I'm thinking about simple/short comments on this to make it clear this naming mismatch is intentional.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13594#discussion_r1177619710


More information about the serviceability-dev mailing list