RFR: 8306851: Move Method access flags

[Chris Plummer]

On Tue, 25 Apr 2023 19:09:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This change moves the flags from AccessFlags to either ConstMethodFlags or MethodFlags, depending on whether they are set at class file parse time, which makes them essentially const, or at runtime, which makes them needing atomic access.
> 
> This leaves AccessFlags int size because Klass still has JVM flags that are more work to move, but this change doesn't increase Method size.  I didn't remove JVM_RECOGNIZED_METHOD_MODIFIERS with this change since there are several of these in other places, and with this change the code is benign.
> 
> Tested with tier1-6, and some manual verification of printing.

The SA changes look good. I think these changes make @iklam's #13663 fix unnecessary, but harmless.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13654#pullrequestreview-1402521002