RFR: 8291555: Implement alternative fast-locking scheme [v62]

Wed Apr 26 21:08:19 UTC 2023

On Wed, 26 Apr 2023 18:29:36 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/cpu/arm/macroAssembler_arm.cpp line 1803:
>> 
>>> 1801: #ifdef ASSERT
>>> 1802:   // Poison scratch regs
>>> 1803:   POISON_REGS((~savemask), t1, t2, t3, 0x10000001);
>> 
>> Should this poison value be: 0x20000002
>
> The poison values were something I used during development of the arm part, bug hunting wise. Though I think they make sense in general. I agree with @dcubed-ojdk, 0x2000002 would be the most logical value here. Either that or remove the poisening (though it had been useful).

0x20000002 because 0x10000001 was used earlier and it would be good
to keep the poisoning values unique.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1178390683