RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v2]

Chris Plummer cjplummer at openjdk.org
Thu Apr 27 20:54:22 UTC 2023


On Thu, 27 Apr 2023 19:43:51 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some thread -> task renaming
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001a.java line 209:
> 
>> 207: }
>> 208: 
>> 209: class interrupt001aThread implements Runnable {
> 
> Does it make sense to rename class to something like Interrupt001aTask? Just to let know that it is not a thread. Also, there is ./nsk/share/jdi/NamedTask.java for task with names in JDI tests.

Ok. I've made both these changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179660333


More information about the serviceability-dev mailing list