RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class
David Holmes
dholmes at openjdk.org
Tue Aug 1 08:35:49 UTC 2023
On Mon, 31 Jul 2023 15:27:36 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:
>> @ashu-mehra you indicated that you had only done two basic manual tests to check the output. You need to check it for the cases that I flagged too. In the VM every top-level class is its own nest-host, but that is not expressed in a classfile attribute (it is just the defined semantics) so displaying this as-if it were an explicit attribute may not be right.
>
> @dholmes-ora I confirmed there is no nest-host or nest-members attributes generated by this patch for a top level class which doesn't have any nest-members. Is that what you wanted to verify?
@ashu-mehra That was one case. I also want to know that you have tested deeply nested classes; and hidden classes (if applicable). Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15005#issuecomment-1659831895
More information about the serviceability-dev
mailing list