RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class
Ashutosh Mehra
duke at openjdk.org
Thu Aug 3 16:09:33 UTC 2023
On Thu, 3 Aug 2023 15:59:14 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> @ashu-mehra thanks for doing the additional testing. Pity there is no regression/functional test for this.
>
>> @dholmes-ora @plummercj I have improved [dumpclass tests](https://github.com/openjdk/jdk/commit/97618cc9bbadce4b51fc0fbee93557f4dcc8d26a) to cover up some cases for this PR and [JDK-8311971](https://bugs.openjdk.org/browse/JDK-8311971). If the tests makes sense I would like to include it in this PR. Is that okay?
>
> I think given the scope of the changes it would be better to do this with a "Improve SA dumpclass testing" CR/PR.
@plummercj
> I think given the scope of the changes it would be better to do this with a "Improve SA dumpclass testing" CR/PR.
Okay. I guess this can then be integrated as is. Thanks for the reviews.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15005#issuecomment-1664254792
More information about the serviceability-dev
mailing list