RFR: JDK-8313670: Simplify shared lib name handling code in some tests
Chris Plummer
cjplummer at openjdk.org
Fri Aug 4 18:39:32 UTC 2023
On Fri, 4 Aug 2023 09:59:41 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
Changes requested by cjplummer (Reviewer).
test/lib/jdk/test/lib/Platform.java line 376:
> 374: }
> 375: }
> 376:
The following tests could leverage this new API. Just look for calls to `Platform.sharedLibraryExt()`:
test/hotspot/jtreg/runtime/signal/SigTestDriver.java
test/hotspot/jtreg/vmTestbase/nsk/jvmti/NativeLibraryCopier.java
test/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java
Perhaps a `Platform.buildSharedLibraryName()` API is worth considering.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15151#pullrequestreview-1563375724
PR Review Comment: https://git.openjdk.org/jdk/pull/15151#discussion_r1284731606
More information about the serviceability-dev
mailing list