RFR: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects [v3]
Leonid Mesnik
lmesnik at openjdk.org
Fri Aug 4 19:45:56 UTC 2023
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class<?> cls). The previous attempt to post event directly from 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even if jvmti event is not enabled. Some optimizations have been disabled just because possible usage and escaping of newly allocated object.
> So event posting is doing by returning to interpreter if events are enabled.
>
> I verified that that performance (run locally only) of
> org.renaissance.jdk.streams.JmhScrabble.runOperation
> doesn't change if events are not enabled.
>
> There might be other intrinsics like 'LibraryCallKit::inline_unsafe_newArray()' where VM allocate memory. I'm going to file separate issue to find and fix them.
>
> Many thanks to Tobias H. for proposed solution.
>
> Testing with all tiers.
Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
The too many deopts check should be first.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15110/files
- new: https://git.openjdk.org/jdk/pull/15110/files/5095114f..64871b91
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15110&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15110&range=01-02
Stats: 13 lines in 1 file changed: 7 ins; 6 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/15110.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15110/head:pull/15110
PR: https://git.openjdk.org/jdk/pull/15110
More information about the serviceability-dev
mailing list