RFR: 8313654: Test WaitNotifySuspendedVThreadTest.java timed out

Serguei Spitsyn sspitsyn at openjdk.org
Wed Aug 9 05:16:33 UTC 2023


On Tue, 8 Aug 2023 18:50:25 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Test might times out if it suspend thread before it starts breakpoint event handler.
> The fix is to replace sleep with better synchronization and suspend virtual thread only when it runs native code.
> 
> Also, the completed monitor is acquired earlier to avoid racing when completing test.

Looks good.
Thank you for taking care about it.
Thanks,
Serguei

test/hotspot/jtreg/serviceability/jvmti/vthread/WaitNotifySuspendedVThreadTest/WaitNotifySuspendedVThreadTest.java line 27:

> 25:  * @test
> 26:  *
> 27:  * @summary Test verifies that raw jvmti monitor wait/notify works for

Nit: Replace: "raw jvmti monitor" => "JVMTI raw monitor".

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15196#pullrequestreview-1568746812
PR Review Comment: https://git.openjdk.org/jdk/pull/15196#discussion_r1287952993


More information about the serviceability-dev mailing list