RFR: 8311775: [TEST] duplicate verifyHeapDump in several tests [v2]

Kevin Walls kevinw at openjdk.org
Thu Aug 10 17:04:32 UTC 2023


On Thu, 10 Aug 2023 09:41:29 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> This is a follow-up patch of #13667. verifyHeapDump is duplicated in several tests, this patch tries to consolidate them into one method.
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix TestHeapDumpForInvokDynamic

Looks good to me, thanks.
One question on whether we need to change those "throws IOException" to "throws Exception", which is really me thinking if the existing HProfParser parse method really needs to throw Exception?  Maybe it only needs IOException? (snapshot.resolve doesn't throw anything)
But looks good anyway and good to share this code. 8-)

-------------

Marked as reviewed by kevinw (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15202#pullrequestreview-1572336337


More information about the serviceability-dev mailing list