RFR: 8313357: Revisit requiring SA tests on OSX to either run as root or use sudo

Chris Plummer cjplummer at openjdk.org
Wed Aug 16 17:51:09 UTC 2023


On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> On OSX, don't require that sudo be used to launch SA tools if developer mode is enabled. More details are in the CR. 
> 
> Due to this change, the following tests are no longer being skipped if the host has developer mode is enabled. They previously required running as root because if sudo was used some files were created with root ownership and could not be deleted:
> 
> serviceability/sa/ClhsdbDumpclass.java
> serviceability/sa/TestClassDump.java
> 
> I tested on my home system (M1) with developer mode enabled and also disabled. Also tested with CI, which appears to have developer mode disabled on most hosts, but there are a few where it is enabled.

Ping! I could use one more review please. Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15238#issuecomment-1681037101


More information about the serviceability-dev mailing list