RFR: 8314481: JDWPTRANSPORT_ERROR_INTERNAL code in socketTransport.c can never be executed [v2]

[Chris Plummer]

On Thu, 17 Aug 2023 16:33:17 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the following change:
>> 
>> 
>>      if (listenAddr == NULL) {
>> +        // No address of preferred addres family found, grab the fist one.
>> +        listenAddr = &(addrInfo[0]);
>> +    }
>> +
>> +    if (listenAddr == NULL) {
>>          dbgsysFreeAddrInfo(addrInfo);
>>          RETURN_ERROR(JDWPTRANSPORT_ERROR_INTERNAL, "listen failed: wrong address");
>>      }
>> 
>> 
>> After this change it is no longer possible for the RETURN_ERROR block to ever be executed because listenAddr can not ever still be NULL. The entire block should be removed.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix comment typo

Thank you for the reviews Dan and Serguei!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15330#issuecomment-1684238033