RFR: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs [v2]

Tue Aug 22 20:03:49 UTC 2023

On Tue, 22 Aug 2023 07:07:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.cpp line 200:
> 
>> 198:   }
>> 199: 
>> 200:   Atomic::release_store(&_destroyed, 1);
> 
> As discussed in the final review thread for [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) a release_store is not actually needed here as there is no data that we access based on `_destroyed` being set to 1. Hence also no need for `load_acquire` in `is_destroyed()`.

Ok. I've updated it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302120072