RFR: JDK-8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Aug 23 00:54:47 UTC 2023
On Thu, 10 Aug 2023 01:45:47 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
> The change fixes several issues with capability management:
> - handling can_support_virtual_threads capability. JvmtiExport::can_support_virtual_threads() should be set to true if we have one or more agent with can_support_virtual_threads capability;
> - JvmtiManageCapabilities (used by GetPotentialCapabilities/AddCapabilities/RelinquishCapabilities/GetCapabilities) is not thread safe;
> - SuspendAllVirtualThreads and ResumeAllVirtualThreads should check capability on the caller agent (and not JvmtiExport::can_support_virtual_threads()).
>
> Testing: tier1..5
Nice fix, Alex. Looks good.
Thank you for taking care about this issue.
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15219#pullrequestreview-1590543826
More information about the serviceability-dev
mailing list