RFR: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs [v2]

[David Holmes]

On Wed, 23 Aug 2023 00:49:18 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   release_store() and load_acquire() not needed for _destroyed
>
> src/hotspot/share/runtime/perfMemory.hpp line 137:
> 
>> 135:     static size_t capacity() { return _capacity; }
>> 136:     static bool is_initialized();
>> 137:     static bool is_destroyed();
> 
> So don't we need to make changes here? I think we can keep current implementation ( `is_destroyed()` )

Agreed - I assume the change to int was for the release_store etc but that is not needed so we can keep the bool type and existing code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302347968