RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]

Johan Sjölen jsjolen at openjdk.org
Tue Aug 29 09:33:11 UTC 2023


On Mon, 28 Aug 2023 11:03:51 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The `find` method now is 
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>> 
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   find_from_end and its caller are also updated.

I still approve of this patch as it's better than what we had before. There are a lot of suggested improvements that can be done either in this PR or in a future RFE. `git blame` shows that this hasn't been touched since 2008, so I don't think applying all suggestions now is in any sense critical :-).

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15418#pullrequestreview-1599922400


More information about the serviceability-dev mailing list