Integrated: 8189685: need PerfMemory class update and a volatile_static_field support in VMStructs
Chris Plummer
cjplummer at openjdk.org
Tue Aug 29 20:58:21 UTC 2023
On Mon, 21 Aug 2023 21:47:14 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was noted that the PerfMemory _initialized and _destroyed fields should be volatile, but VMStructs didn't have the needed support for doing that, so it was left as a future task. @YaSuenag provided a patch at the time to take care of the VMStructs support. I've integrated it, although it was far from clean due to some changes in VMStructs, and also moving OrderAccess::release_store to Atomic::release_store.
>
> One other change I made to the patch had to do with consistency with using "volatile static" vs "static volatile". We already have volatile_nonstatic_field. The patch renamed static_ptr_volatile_field to static_volatile_field to make it more general purpose, but this was inconsistent with the name of volatile_nonstatic_field, so I chose the name volatile_static_field instead. This carried over into some other areas like the names of the GENERATE_VOLATILE_STATIC_VM_STRUCT_ENTRY and CHECK_VOLATILE_STATIC_VM_STRUCT_ENTRY macros.
This pull request has now been integrated.
Changeset: b2728cb1
Author: Chris Plummer <cjplummer at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/b2728cb139c9d8d378820f848afe8e83fe5be471
Stats: 17 lines in 5 files changed: 2 ins; 0 del; 15 mod
8189685: need PerfMemory class update and a volatile_static_field support in VMStructs
Reviewed-by: ysuenaga, dholmes, sspitsyn
-------------
PR: https://git.openjdk.org/jdk/pull/15373
More information about the serviceability-dev
mailing list