RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v2]
Leonid Mesnik
lmesnik at openjdk.org
Wed Aug 30 22:57:01 UTC 2023
On Wed, 30 Aug 2023 22:31:43 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Not exactly, the stderr is just ignored. We don't expect anything so just ignore it.
>
> So previously we would terminate the debuggee the first time we saw any output on stderr, and now instead we ignore stderr. What if instead we process stderr the same as stdout? Would that cause a failure because the output is not what the test expects? What if there really is an issue launching the JVM that is expressed on stderr? Wouldn't we want that detected by this code?
Agree, lets process stderr like stdout. This shouldn't change logic of test but allow us at least to see stderr.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1310914239
More information about the serviceability-dev
mailing list