RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v2]

Leonid Mesnik lmesnik at openjdk.org
Thu Aug 31 00:07:21 UTC 2023


On Wed, 30 Aug 2023 23:28:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   restore errorhandler
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 110:
> 
>> 108:     @Override
>> 109:     public void onStringRead(StreamHandler handler, String line) {
>> 110:         processDebuggeeOutput(line);
> 
> You might want to look at #4560, which added the onDebuggeeError() code, which is no longer being called from anywhere after this change. @alexmenkov

This method existed from beginning. I'll remove it.
See: https://github.com/openjdk/jdk/commit/4f55b6c7e03687e9b799456d6e4d0b82027566ec

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1310959495


More information about the serviceability-dev mailing list