RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code
David Holmes
dholmes at openjdk.org
Thu Aug 31 05:03:00 UTC 2023
On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
> Please review this simple change from @cjmoon1 for resolving static linking issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be found at: https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize.
>
> The change incorporated suggestions from both @sspitsyn and myself:
>
> - https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187
> - https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187
Is `normalize` the only function that causes a conflict and the other changes are just for consistency? If so please just rename normalize to e.g. `normalize_path`
-------------
PR Review: https://git.openjdk.org/jdk/pull/15477#pullrequestreview-1603949761
More information about the serviceability-dev
mailing list