RFR: 8320652: ThreadInfo.isInNative needs to be updated to say what executing native code means [v3]

Mandy Chung mchung at openjdk.org
Fri Dec 1 17:59:09 UTC 2023


On Fri, 1 Dec 2023 12:16:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> This is a docs only change to j.l.management.ThreadInfo::isInNative. 
>> 
>> The method currently specifies that it tests if the thread is  "executing native code via the Java Native Interface (JNI)".  It would be clearer to say that it tests if the thread is executing a native method, and expand it to include native code invoked using the new foreign linker APIs. For now, I've left out the detail of a downcall handle created with the "critical" linker option.
>
> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Extend description
>  - Merge
>  - Change link to downcallHandle
>  - Merge
>  - Simplify wording
>  - Merge
>  - Initial commit

The updated spec change looks good.

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16791#pullrequestreview-1760317046


More information about the serviceability-dev mailing list