RFR: 8321069: JvmtiThreadState::state_for_while_locked() returns nullptr for an attached JNI thread with a java.lang.Thread object after JDK-8319935 [v2]
Jiangli Zhou
jiangli at openjdk.org
Mon Dec 4 19:06:00 UTC 2023
On Mon, 4 Dec 2023 18:16:52 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> In the fix for the following bug:
>>
>> [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
>>
>> JvmtiThreadState::state_for_while_locked() was changed to
>> return nullptr for attaching JNI threads regardless of whether
>> that JNI thread/JavaThread had a java.lang.Thread object.
>>
>> We should only filter out a JavaThread that's attaching via JNI
>> if it has no java.lang.Thread object.
>>
>> This fix has been tested with Mach5 Tier[1-7] and there are no related test failures.
>> Mach5 Tier8 is in process.
>>
>> I'm going to need @jianglizhou to rerun her testing for:
>>
>> [JDK-8319935](https://bugs.openjdk.org/browse/JDK-8319935) Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
>>
>> since the test(s) for that fix are not yet integrated in the jdk/jdk repo.
>
> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>
> dholmes CR - adjust a comment.
Marked as reviewed by jiangli (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16934#pullrequestreview-1763177973
More information about the serviceability-dev
mailing list