RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS [v2]
David Holmes
dholmes at openjdk.org
Mon Dec 4 23:38:33 UTC 2023
On Mon, 4 Dec 2023 12:35:42 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Thanks for looking at this @AlanBateman and @sspitsyn . I was trying to refer to the JNI text in a casual way rather than duplicating the actual content from there. This was more a strong hint/suggestion to "go read the JNI spec for details".
>>
>> Happy to change 'form' to 'format'.
>
> I agree with not duplicating the entire sentence but what would you think about replacing the text in the parenthesis with "Note the required = between option and value". Only asking because "(not "option value")" isn't as clear that we want the reader to see that you can't use a space here.
Okay. I thought it very clear to say "use format X (not format Y)", but sure I can change it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16896#discussion_r1414637979
More information about the serviceability-dev
mailing list