RFR: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected

[David Holmes]

On Tue, 5 Dec 2023 00:23:45 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The fix is for a regression caused by:
>  [8308614](https://bugs.openjdk.org/browse/JDK-8308614) Enabling JVMTI ClassLoad event slows down vthread creation by factor 10
> 
> The fix of 8308614 just triggered a known issue:
>   [8316283](https://bugs.openjdk.org/browse/JDK-8316283) field watch events are not always posted with -Xcomp option
>   
> The fix is just a work around with the extra checks with the `JvmtiExport::should_post_field_access()` and `JvmtiExport::should_post_field_modification()`.
> 
> Testing:
> - The test `runtime/jni/FastGetField/FastGetField.java` does not fail anymore with this fix
> - In progress: Test with tiers 1-6

src/hotspot/share/prims/jvmtiThreadState.cpp line 562:

> 560:   if (JvmtiThreadState::seen_interp_only_mode() ||
> 561:       JvmtiExport::should_post_field_access() ||
> 562:       JvmtiExport::should_post_field_modification()){

The comment needs updating to explain the extra checks.

Can't say I see the connection with [8316283](https://bugs.openjdk.org/browse/JDK-8316283) as no `-Xcomp` is involved in the current failures AFAICS.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16961#discussion_r1414867564