RFR: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected [v2]

David Holmes dholmes at openjdk.org
Wed Dec 6 02:28:45 UTC 2023


On Tue, 5 Dec 2023 23:01:20 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: extended comment to cover the watchpoint extra checks
>
> Thumbs up. This is a trivial fix.
> 
> You'll need to fix the whitespace complaint before integration.

@dcubed-ojdk I would not consider this a trivial fix at all - the need to add the additional conditions is not at all obvious! And even if they were, that would make this a small/simple fix, not "trivial" as defined for the "one review needed" rule.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16961#issuecomment-1841982060


More information about the serviceability-dev mailing list