RFR: 8314029: Add file name parameter to Compiler.perfmap [v7]
Chris Plummer
cjplummer at openjdk.org
Mon Dec 11 21:43:36 UTC 2023
On Thu, 7 Dec 2023 22:49:55 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:
>> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: `/tmp/perf-%d.map`. This change adds an optional argument for specifying a file name.
>>
>> `jcmd PID help Compiler.perfmap` shows the following usage.
>>
>>
>> Compiler.perfmap
>> Write map file for Linux perf tool.
>>
>> Impact: Low
>>
>> Syntax : Compiler.perfmap [<filename>]
>>
>> Arguments:
>> filename : [optional] Name of the map file (STRING, no default value)
>>
>>
>> The following section of man page is also updated. (`man -l src/jdk.jcmd/share/man/jcmd.1`)
>>
>>
>> Compiler.perfmap [arguments] (Linux only)
>> Write map file for Linux perf tool.
>>
>> Impact: Low
>>
>> arguments:
>>
>> · filename: (Optional) Name of the map file (STRING, no default value)
>>
>> If filename is not specified, a default file name is chosen using the pid of the target JVM process. For example, if the pid is 12345, then
>> the default filename will be /tmp/perf-12345.map.
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>
> use default argument of write_perf_map
The test needs a copyright update. Otherwise the changes look good.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15871#pullrequestreview-1776216918
More information about the serviceability-dev
mailing list