RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v4]
Joachim Kern
jkern at openjdk.org
Fri Dec 15 11:27:47 UTC 2023
On Fri, 15 Dec 2023 07:01:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1174:
>
>> 1172: struct _S_(ldhdr) ldr64;
>> 1173: memcpy((char*)&xcoff64, buffer, FILHSZ_64 + _AOUTHSZ_EXEC_64);
>> 1174: int ldroffset = FILHSZ_64 + xcoff64.filehdr.f_opthdr + (xcoff64.aouthdr.o_snloader -1)*SCNHSZ_64;
>
> why the -1? I assume thats the section number? is it 1 based? how odd..
Yes, the section numbers are 1 based. e.g. Beginning of section 4 has an offset of 3 section sizes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1427866203
More information about the serviceability-dev
mailing list