RFR: JDK-8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix length

[Chris Plummer]

On Fri, 15 Dec 2023 19:43:36 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The fix updated JdwpAllowTest to test negative scenarios (debugger tries to attach from not allowed address).
> 
> MaskTest ctor incorrectly calculates prefix length for negative tests and test main() calls `positiveTest` instead of `negativeTest` for `prefixLengthBad`.
> 
> Also fixes test output:
> LingeredApp logs to System.out and the test logs to System.err, this makes harder log analysis.

Changes look good.

I'd support a PR to change all uses of System.err in our tests to System.out. I'm not so sure there is ever a case where we don't want to see the errors in the same stream as regular log message. I'm tired of seeing System.err dumps at the end of the test output, and not knowing where it happened relative to the System.out output.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17131#pullrequestreview-1785091559